Skip to content

[Local catalog] Show errors when syncing in settings #16388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 25, 2025
Merged

[Local catalog] Show errors when syncing in settings #16388

merged 6 commits into from
Nov 25, 2025

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Nov 24, 2025

Description

This PR presents modal errors from resyncing the catalog in settings.

I extracted the content from POSListErrorView to POSErrorView, and reused it for these errors.

Test Steps

  • Set the version to 23.8
  • Launch the app and open POS
  • Open POS Settings > Local catalog
  • Set a block or breakpoint on /wc/v3/products* and abort all the requests from here on out
  • Tap Refresh catalog
  • Observe that the error is shown, and you can retry or cancel it

Screenshots

Errors.on.refresh.mp4
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added this to the 23.8 milestone Nov 24, 2025
@joshheald joshheald added type: task An internally driven task. feature: POS labels Nov 24, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 24, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 24, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16388-a6b295f
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commita6b295f
Installation URL6i0qp3tq4ju20
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

iamgabrielma
iamgabrielma approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@joshheald joshheald merged commit d2f2ba4 into trunk Nov 25, 2025
14 checks passed
@joshheald joshheald deleted the woomob-1765-local-catalog-show-errors-when-syncing-in-settings branch November 25, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamgabrielma iamgabrielma iamgabrielma approved these changes

Assignees

No one assigned

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Milestone

23.8 ❄️

Development

Successfully merging this pull request may close these issues.

5 participants

@joshheald @dangermattic @wpmobilebot @iamgabrielma